Conversation
alexmohr
force-pushed
the
init
branch
27 times, most recently
from
f74d883 to
9470dd8
Compare
alexmohr
force-pushed
the
init
branch
2 times, most recently
from
cde052e to
43933ee
Compare
|
I still have to test this in repo with rust code, so all checks run. @lh-sag did I miss some checks or any suggestions for more things to add? All checks are moved to pre-commit now because it is annoying to run multiple tools (uv, license-check, cargo fmt, taplo, etc), so everything can be done via uv now. |
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: Run checks | ||
| uses: eclipse-opensovd/cicd-workflows/pre-commit-action@init |
There was a problem hiding this comment.
must be init until we have this on main, immediately after merging this, we need a second PR changing this to main.
| inputs: | ||
| rust-nightly-version: | ||
| description: 'Rust nightly version to use (YYYY-MM-DD)' | ||
| required: false |
There was a problem hiding this comment.
question: would it make sense if the descriptions include what happens if nothing is set - e.g. "the default value defined in action.yml is used" for this and the others?
There was a problem hiding this comment.
thanks, added it :)
| copyright-owner: The Contributors to Eclipse OpenSOVD | ||
| software-name: opensovd-cda | ||
| content: | | ||
| Copyright (c) 2025 The Contributors to Eclipse OpenSOVD (see CONTRIBUTORS) |
There was a problem hiding this comment.
question: should we add LICENSE, NOTICE and CONTRIBUTORS? Since this repo is open-source, it could serve as an example for how we'd expect them in new projects
There was a problem hiding this comment.
@floroks Could you please take a look and re-approve in case you're happy with the changes? Thank you.
* pre commit check with uv * license header check Signed-off-by: Alexander Mohr <[email protected]>
2 participants
Summary
Pre-commit Action
Multi-language code quality checks:
All formatters auto-fix issues and fail on changes.
Local Execution
run_checks.pydownloads shared configuration and runs identical checks locally.Configuration
Default values for all inputs with fallback handling when empty strings are passed:
This repo is also using it's own pipeline to verify things.
Checklist
Related
Notes for Reviewers
Alexander Mohr [email protected], Mercedes-Benz Tech Innovation GmbH
Provider Information